[feat #153] 채팅 요청 자동 거절 알림 생성 #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
Test Results 28 files 28 suites 13s ⏱️ Results for commit a06dfe4. ♻️ This comment has been updated with latest results. |
Code Coverage
|
hyun2371
approved these changes
Nov 28, 2024
| @@ -129,11 +130,33 @@ public RejectChatResponse rejectChat(Long chatInquiryId, Member answerer) { | |||
| @Transactional | |||
| public void rejectChatAuto() { | |||
| List<Long> rejectedInquirerIds = chatInquiryRepository.getAutoRejectedInquirerIds(); | |||
| List<RejectChatInquiryDto> rejectChatInquiryDtos = chatInquiryRepository.getAutoRejectedChatInquiry(); | |||
There was a problem hiding this comment.
List<Long> rejectedInquirerIds = rejectChatInquiryDtos.stream()
.map(dto -> dto.inquirer().getId())
.toList()위 코드를 추가하면 쿼리를 두 번 날릴 필요없이, 하나의 쿼리만 사용할 수 있을 것 같아요!
There was a problem hiding this comment.
안그래도 쿼리를 줄일 수 없나 고민했었는데 좋은 방법이네요!
| import com.dnd.gongmuin.member.domain.Member; | ||
| import com.querydsl.core.annotations.QueryProjection; | ||
|
|
||
| public record RejectChatInquiryDto( |
| @@ -14,4 +15,6 @@ public interface ChatInquiryQueryRepository { | |||
| List<Long> getAutoRejectedInquirerIds(); | |||
|
|
|||
| void updateChatInquiryStatusRejected(); | |||
|
|
|||
| List<RejectChatInquiryDto> getAutoRejectedChatInquiry(); | |||
There was a problem hiding this comment.
리스트 조회 메서드니까 복수형으로 Inquires가 되어야 할 것 같습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
📑 작업 상세 내용
RejectChatInquiryDto)💫 작업 요약
🔍 중점적으로 리뷰 할 부분
triggerMemberId가 필요합니다. 답변자가 채팅 요청에 대해 응답하지 않아 자동 거절된거니 답변자를 trigger로 생각했었지만, 자동 거절한 주체는 '시스템'이라고 생각되었습니다. 하지만 시스템은 memberId가 없기에 trigger를 자기 자신으로 넣어놓긴 했습니다.