[fix #161] 채팅 요청 시 크레딧 감소 안되는 오류 해결 #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
|
Test Results 28 files 28 suites 15s ⏱️ Results for commit d866184. |
dudxo
approved these changes
Nov 29, 2024
| @@ -35,6 +35,7 @@ public static CreateChatInquiryResponse toCreateChatInquiryResponse( | |||
| chatInquiry.getId(), | |||
| chatInquiry.getMessage(), | |||
| InquiryStatus.PENDING.getLabel(), | |||
| chatInquiry.getInquirer().getCredit(), | |||
There was a problem hiding this comment.
채팅 요청 성공 응답에 잔여 크래딧을 추가하신 이유가 무엇인가요? 궁금해서 질문드립니다!
There was a problem hiding this comment.
채팅 요청 시 크레딧이 제대로 차감됐는지, 잔여 크레딧은 얼마인지 유저에게 응답해줘야 할 것 같아서요! 화면 UI 상으로도 필요하다고 생각합니다
There was a problem hiding this comment.
그렇군요, 지금 해당 디자인 UI 설계가 되어있나요? UI 설계에 따라 약간 불필요하다는 느낌도 조금 드네요!
| ChatInquiry chatInquiry = chatInquiryRepository.save( | ||
| ChatInquiryMapper.toChatInquiry(questionPost, inquirer, answerer, request.inquiryMessage()) | ||
| ); | ||
|
|
||
| memberRepository.save(inquirer); | ||
| creditHistoryService.saveChatCreditHistory(CreditType.CHAT_REQUEST, inquirer); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
📑 작업 상세 내용
💫 작업 요약