Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix #171] status enum 타입 String으로 변경 #172

Merged
merged 4 commits into from
Dec 12, 2024
Merged

[fix #171] status enum 타입 String으로 변경 #172

merged 4 commits into from
Dec 12, 2024

Conversation

hyun2371
Copy link
Member

@hyun2371 hyun2371 commented Dec 12, 2024 •
edited
Loading

관련 이슈

📑 작업 상세 내용

  • 추가된 questionpost 상태필드의 enum 타입 수정
    • ordinal->String
  • 다른 엔티티와 일관성 위해 status로 변경
  • enum 내 상수들 형용사로 통일

💫 작업 요약

🔍 중점적으로 리뷰 할 부분

@hyun2371 hyun2371 linked an issue Dec 12, 2024 that may be closed by this pull request
🚨 status enum 타입 String으로 변경 #171
Closed
@github-actions GitHub Actions
Copy link

Code Coverage

Overall Project 83.5% 🍏
Files changed 100% 🍏

File Coverage
QuestionPostQueryRepositoryImpl.java 96.91% 🍏
QuestionPost.java 93.53% 🍏
AnswerService.java 88.37% 🍏
QuestionPostStatus.java 60.78% 🍏

@github-actions GitHub Actions
Copy link

Test Results

 28 files   28 suites   15s ⏱️
137 tests 135 ✅ 2 💤 0 ❌
138 runs  136 ✅ 2 💤 0 ❌

Results for commit f0b6958.

@hyun2371 hyun2371 requested a review from dudxo December 12, 2024 10:07
@hyun2371 hyun2371 self-assigned this Dec 12, 2024
@hyun2371 hyun2371 added the 🚨 fix 오류 수정 label Dec 12, 2024
@hyun2371 hyun2371 merged commit 9c0dac8 into dev Dec 12, 2024
3 checks passed
@hyun2371 hyun2371 deleted the fix/#171/enum_type_string branch December 27, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudxo dudxo dudxo approved these changes

Assignees

@hyun2371 hyun2371

Labels
🚨 fix 오류 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚨 status enum 타입 String으로 변경
2 participants
@hyun2371 @dudxo