Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix #69] 프론트 요청 시 쿠키 값을 읽지 못하는 issue 해결 #70

Merged
merged 2 commits into from
Aug 22, 2024
Merged

[fix #69] 프론트 요청 시 쿠키 값을 읽지 못하는 issue 해결 #70

merged 2 commits into from
Aug 22, 2024

Conversation

dudxo
Copy link
Collaborator

@dudxo dudxo commented Aug 22, 2024

관련 이슈

📑 작업 상세 내용

  • 쿠키 설정 시 Same-Stie None 설정
  • 쿠키 설정 시 Secure 설정
  • CORS 수정

💫 작업 요약

  • 쿠키 설정 시 Same-Stie None 설정
  • 쿠키 설정 시 Secure 설정
  • CORS 수정

🔍 중점적으로 리뷰 할 부분

  • cookie를 원활하게 ㅅ쓰려면 도메인이 같아야 하는데 달라서 좀 문제가 생기네요,,

@dudxo dudxo added 🚨 fix 오류 수정 빠른 리뷰! 빠른 PR 리뷰가 필요할 때 labels Aug 22, 2024
@dudxo dudxo requested a review from hyun2371 August 22, 2024 07:58
@dudxo dudxo self-assigned this Aug 22, 2024
@dudxo dudxo linked an issue Aug 22, 2024 that may be closed by this pull request
🚨 프론트 요청 시 쿠키 값을 읽지 못하는 issue #69
Closed
@github-actions GitHub Actions
Copy link

Code Coverage

Overall Project 81.58% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Test Results

84 tests   84 ✅  11s ⏱️
18 suites   0 💤
18 files     0 ❌

Results for commit 4a1d729.

@dudxo dudxo merged commit a804891 into dev Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyun2371 hyun2371 hyun2371 approved these changes

Assignees

@dudxo dudxo

Labels
빠른 리뷰! 빠른 PR 리뷰가 필요할 때 🚨 fix 오류 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚨 프론트 요청 시 쿠키 값을 읽지 못하는 issue
2 participants
@dudxo @hyun2371