Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BLOOM-083] 내 식물 등록/수정 방법 변경 #84

Merged
merged 3 commits into from
Aug 23, 2024
Merged

[BLOOM-083] 내 식물 등록/수정 방법 변경 #84

merged 3 commits into from
Aug 23, 2024

Conversation

Dompoo
Copy link
Collaborator

@Dompoo Dompoo commented Aug 23, 2024 •
edited
Loading

How

  • Request dto에서 LocalDate 값이 아닌 Int값을 받도록 했습니다.
  • 이에따라 spring validation도 적절하게 수정하였습니다.
  • 테스트 오류를 수정하였습니다.

Result

  • 식물 등록 시에 마지막으로 물/비료 준 날을 날짜가 아니라 선택지 번호(Int)로 받습니다.
  • 식물 수정 시에 마지막으로 물/비료 준 날을 날짜가 아니라 선택지 번호(Int)로 받습니다.

@Dompoo Dompoo added the 🔨 fix Request a fix for an existing feature label Aug 23, 2024
@Dompoo Dompoo self-assigned this Aug 23, 2024
@Dompoo Dompoo requested a review from stophwan as a code owner August 23, 2024 01:03
stophwan
stophwan approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@stophwan stophwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~~!

@Dompoo Dompoo merged commit a27ae2f into main Aug 23, 2024
1 check passed
@Dompoo Dompoo linked an issue Aug 23, 2024 that may be closed by this pull request
[fix] 내 식물 등록방식 변경 #83
Closed
@Dompoo Dompoo deleted the fix/add-my-plant branch August 23, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stophwan stophwan stophwan approved these changes

Assignees

@Dompoo Dompoo

Labels
🔨 fix Request a fix for an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] 내 식물 등록방식 변경
2 participants
@Dompoo @stophwan