[BLOOM-089] 위치등록시 위치명 중복 예외 추가 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Dompoo
commented
Aug 28, 2024
Dompoo
commented
- ErrorType을 정의하고, LocationService에서 조건을 체크한 후 예외를 터트리도록 했습니다.
- 이제 중복된 Location명에 대해 체크할 수 있게 되었습니다.
Closed
stophwan
reviewed
Aug 29, 2024
Comment on lines
27
to
34
| val locations = locationRepository.findAllByUser(user) | ||
|
|
||
| if (locations.size >= MAX_LOCATION_LIMIT) throw BadRequestException(ErrorType.LOCATION_COUNT_EXCEED) | ||
| if (locations.any { location -> | ||
| location.name == dto.name | ||
| } | ||
| ) { | ||
| throw BadRequestException(ErrorType.LOCATION_NAME_DUPLICATE) |
There was a problem hiding this comment.
'위치 등록 한도가 넘었을때' '이미 등록된 위치에 등록하려했을때' 두 가지 예외사항이 있는데 둘 다 별도의 private 메서드로 하면 가독성이 높아지지 않을까 생각합니다.
There was a problem hiding this comment.
좋은 지점인 것 같아요! 리팩터링 했습니다~ refactor: LocationService 검증 코드를 별도의 private 메서드로 추출
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.