refactor(member): return 201 created when profile image was uploaded

dnd-side-project · Apr 4, 2023 · 4930504 · 4930504
1 parent 2985a28
commit 4930504
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/main/java/com/dnd/weddingmap/domain/member/controller/MemberController.java b/src/main/java/com/dnd/weddingmap/domain/member/controller/MemberController.java
@@ -13,6 +13,7 @@
 import com.dnd.weddingmap.global.util.MessageUtil;
 import jakarta.validation.Valid;
 import lombok.RequiredArgsConstructor;
+import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
 import org.springframework.security.core.annotation.AuthenticationPrincipal;
 import org.springframework.web.bind.annotation.DeleteMapping;
@@ -96,9 +97,11 @@ public ResponseEntity<SuccessResponse> postProfileImage(
     }
     memberService.putProfileImage(user.getId(), imageUrl);
 
-    return ResponseEntity.ok(SuccessResponse.builder()
-        .data(new ProfileImageDto(imageUrl))
-        .build());
+    return ResponseEntity.status(HttpStatus.CREATED).body(
+        SuccessResponse.builder()
+            .httpStatus(HttpStatus.CREATED)
+            .data(new ProfileImageDto(imageUrl))
+            .build());
   }
 
   @DeleteMapping

diff --git a/src/test/java/com/dnd/weddingmap/domain/member/controller/MemberControllerTest.java b/src/test/java/com/dnd/weddingmap/domain/member/controller/MemberControllerTest.java
@@ -206,7 +206,7 @@ void postProfile() throws Exception {
     );
 
     // then
-    result.andExpect(status().isOk())
+    result.andExpect(status().isCreated())
         .andDo(document("member/put-profile",
             requestHeaders(
                 headerWithName(HttpHeaders.AUTHORIZATION).description("액세스 토큰")