rm: support removing multiple builders at once #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedevc
reviewed
Nov 28, 2023
AkihiroSuda
reviewed
Dec 9, 2023
tonistiigi
reviewed
Dec 22, 2023
| if err != nil { | ||
| return err | ||
| } | ||
| eg, _ := errgroup.WithContext(ctx) |
There was a problem hiding this comment.
Is it intentional that you are not passing the errgroup context to goroutines?
There was a problem hiding this comment.
Yes this is intentional so even if one builder removal fails, it will continue with the removal of the remaining builders.
Signed-off-by: CrazyMax <[email protected]>
tonistiigi
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
docker rm, it gives the possibility to remove one or more builder instances at once.