Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: set local dirs as frontend attributes #2156

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Dec 13, 2023

Set local dirs metadata if relative to working VCS directory so dockerfile path is tracked accurately.

@crazy-max crazy-max requested a review from tonistiigi December 14, 2023 09:38
@crazy-max crazy-max marked this pull request as ready for review December 14, 2023 09:38
@crazy-max crazy-max force-pushed the frontend-attr-localdirs branch from 144d1b7 to e3466d9 Compare December 15, 2023 14:33
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build/git.go Outdated Show resolved Hide resolved
build/git.go Outdated Show resolved Hide resolved
build/git.go Outdated Show resolved Hide resolved
build/build.go Outdated Show resolved Hide resolved
@crazy-max crazy-max force-pushed the frontend-attr-localdirs branch 3 times, most recently from 8ef55c4 to 0f72361 Compare December 19, 2023 08:23
@crazy-max crazy-max requested a review from tonistiigi December 19, 2023 08:23
@crazy-max crazy-max force-pushed the frontend-attr-localdirs branch from 0f72361 to 7b4f991 Compare December 19, 2023 14:01
build/git.go Outdated Show resolved Hide resolved
build/git.go Outdated Show resolved Hide resolved
@crazy-max crazy-max force-pushed the frontend-attr-localdirs branch from 7b4f991 to 93ef603 Compare December 20, 2023 15:16
Set local dirs metadata if relative to VCS directory so
dockerfile path is tracked accurately in case vcs information
is not fulfilled.

Signed-off-by: CrazyMax <[email protected]>
@crazy-max crazy-max force-pushed the frontend-attr-localdirs branch from 93ef603 to 02bc4e8 Compare December 21, 2023 10:38
@crazy-max crazy-max added this to the v0.13.0 milestone Dec 23, 2023
Copy link
Contributor

@cdupuis cdupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for the PR. It solves a big challenge for Scout.

@tonistiigi tonistiigi merged commit 671347d into docker:master Jan 3, 2024
61 checks passed
@crazy-max crazy-max deleted the frontend-attr-localdirs branch January 3, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants