Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use absolute links and update link targets #2253

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Feb 9, 2024

Signed-off-by: David Karlsson [email protected]

@dvdksn dvdksn requested a review from crazy-max February 9, 2024 16:52
@dvdksn dvdksn marked this pull request as ready for review February 9, 2024 16:52
@dvdksn
Copy link
Contributor Author

dvdksn commented Feb 9, 2024

Docs upstream workflow will be broken until main is updated

Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this absolutely needed? It breaks the links when viewing md files in github.

@dvdksn
Copy link
Contributor Author

dvdksn commented Feb 10, 2024

Alternatively we patch cli-docs-tool to rewrite the links when generating yaml. @thaJeztah had the same concern. But that could be something for a follow-up I think.

@dvdksn dvdksn force-pushed the docs-cli-reference-urlscheme branch 2 times, most recently from 9ae59a4 to 8a25f63 Compare February 12, 2024 08:41
@thaJeztah
Copy link
Member

Alternatively we patch cli-docs-tool to rewrite the links when generating yaml. @thaJeztah had the same concern. But that could be something for a follow-up I think.

@dvdksn dvdksn force-pushed the docs-cli-reference-urlscheme branch 2 times, most recently from 2284a49 to 07ac568 Compare February 20, 2024 07:43
Signed-off-by: David Karlsson <[email protected]>
@dvdksn dvdksn force-pushed the docs-cli-reference-urlscheme branch from 07ac568 to cdfc35d Compare February 20, 2024 07:56
@crazy-max crazy-max merged commit 97e8fa7 into docker:master Feb 20, 2024
64 of 65 checks passed
@dvdksn dvdksn deleted the docs-cli-reference-urlscheme branch February 20, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants