Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile: update to docker v27.4.0 #2830

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Dockerfile: update to docker v27.4.0 #2830

merged 1 commit into from
Dec 10, 2024

Conversation

thaJeztah
Copy link
Member

No description provided.

@thaJeztah thaJeztah self-assigned this Nov 29, 2024
@thaJeztah thaJeztah requested a review from crazy-max December 2, 2024 08:53
@thaJeztah thaJeztah changed the title Dockerfile: update to docker v27.4.0-rc.3 Dockerfile: update to docker v27.4.0-rc.4 Dec 5, 2024
@thaJeztah
Copy link
Member Author

Updated to rc.4

@thaJeztah thaJeztah changed the title Dockerfile: update to docker v27.4.0-rc.4 Dockerfile: update to docker v27.4.0 Dec 9, 2024
@thaJeztah
Copy link
Member Author

Updated to v27.4.0

@thaJeztah
Copy link
Member Author

@crazy-max any ideas on this failure? Is it somehow building for the wrong arch, or picking up cache for the wrong one?

25 [linux/amd64->windows/arm64 buildx-build 1/1] RUN --mount=type=bind,target=.   --mount=type=cache,target=/root/.cache   --mount=type=cache,target=/go/pkg/mod   --mount=type=bind,from=buildx-version,source=/buildx-version,target=/buildx-version <<EOT (set -e...)
#25 0.068 + CGO_ENABLED=0 go build -mod vendor -trimpath -ldflags '-X github.com/docker/buildx/version.Version=df70f75 -X github.com/docker/buildx/version.Revision=df70f7519b6457f68692c0a14423d47667536db5 -X github.com/docker/buildx/version.Package=github.com/docker/buildx -s -w' -o /usr/bin/docker-buildx ./cmd/buildx
#25 61.93 /usr/bin/docker-buildx: PE32+ executable for MS Windows 6.01 (console), ARM64, 6 sections
#25 61.95 file /usr/bin/docker-buildx does not match expected target architecture arm64: PE32+ executable for MS Windows 6.01 (console), ARM64, 6 sections
#25 ERROR: process "/bin/sh -c   set -e\n  xx-go --wrap\n  DESTDIR=/usr/bin VERSION=$(cat /buildx-version/version) REVISION=$(cat /buildx-version/revision) GO_EXTRA_LDFLAGS=\"-s -w\" ./hack/build\n  file /usr/bin/docker-buildx\n  xx-verify --static /usr/bin/docker-buildx\n" did not complete successfully: exit code: 1
------
 > [linux/amd64->windows/arm64 buildx-build 1/1] RUN --mount=type=bind,target=.   --mount=type=cache,target=/root/.cache   --mount=type=cache,target=/go/pkg/mod   --mount=type=bind,from=buildx-version,source=/buildx-version,target=/buildx-version <<EOT (set -e...):
0.068 + CGO_ENABLED=0 go build -mod vendor -trimpath -ldflags '-X github.com/docker/buildx/version.Version=df70f75 -X github.com/docker/buildx/version.Revision=df70f7519b6457f68692c0a14423d47667536db5 -X github.com/docker/buildx/version.Package=github.com/docker/buildx -s -w' -o /usr/bin/docker-buildx ./cmd/buildx
61.93 /usr/bin/docker-buildx: PE32+ executable for MS Windows 6.01 (console), ARM64, 6 sections
61.95 file /usr/bin/docker-buildx does not match expected target architecture arm64: PE32+ executable for MS Windows 6.01 (console), ARM64, 6 sections
------
Dockerfile:76
--------------------
  75 |     ARG GO_EXTRA_FLAGS
  76 | >>> RUN --mount=type=bind,target=. \
  77 | >>>   --mount=type=cache,target=/root/.cache \
  78 | >>>   --mount=type=cache,target=/go/pkg/mod \
  79 | >>>   --mount=type=bind,from=buildx-version,source=/buildx-version,target=/buildx-version <<EOT
  80 | >>>   set -e
  81 | >>>   xx-go --wrap
  82 | >>>   DESTDIR=/usr/bin VERSION=$(cat /buildx-version/version) REVISION=$(cat /buildx-version/revision) GO_EXTRA_LDFLAGS="-s -w" ./hack/build
  83 | >>>   file /usr/bin/docker-buildx
  84 | >>>   xx-verify --static /usr/bin/docker-buildx
  85 | >>> EOT
  86 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c   set -e\n  xx-go --wrap\n  DESTDIR=/usr/bin VERSION=$(cat /buildx-version/version) REVISION=$(cat /buildx-version/revision) GO_EXTRA_LDFLAGS=\"-s -w\" ./hack/build\n  file /usr/bin/docker-buildx\n  xx-verify --static /usr/bin/docker-buildx\n" did not complete successfully: exit code: 1
make: *** [Makefile:35: release] Error 1
Error: Process completed with exit code 2.

@crazy-max
Copy link
Member

@crazy-max any ideas on this failure? Is it somehow building for the wrong arch, or picking up cache for the wrong one?

25 [linux/amd64->windows/arm64 buildx-build 1/1] RUN --mount=type=bind,target=.   --mount=type=cache,target=/root/.cache   --mount=type=cache,target=/go/pkg/mod   --mount=type=bind,from=buildx-version,source=/buildx-version,target=/buildx-version <<EOT (set -e...)
#25 0.068 + CGO_ENABLED=0 go build -mod vendor -trimpath -ldflags '-X github.com/docker/buildx/version.Version=df70f75 -X github.com/docker/buildx/version.Revision=df70f7519b6457f68692c0a14423d47667536db5 -X github.com/docker/buildx/version.Package=github.com/docker/buildx -s -w' -o /usr/bin/docker-buildx ./cmd/buildx
#25 61.93 /usr/bin/docker-buildx: PE32+ executable for MS Windows 6.01 (console), ARM64, 6 sections
#25 61.95 file /usr/bin/docker-buildx does not match expected target architecture arm64: PE32+ executable for MS Windows 6.01 (console), ARM64, 6 sections
#25 ERROR: process "/bin/sh -c   set -e\n  xx-go --wrap\n  DESTDIR=/usr/bin VERSION=$(cat /buildx-version/version) REVISION=$(cat /buildx-version/revision) GO_EXTRA_LDFLAGS=\"-s -w\" ./hack/build\n  file /usr/bin/docker-buildx\n  xx-verify --static /usr/bin/docker-buildx\n" did not complete successfully: exit code: 1
------
 > [linux/amd64->windows/arm64 buildx-build 1/1] RUN --mount=type=bind,target=.   --mount=type=cache,target=/root/.cache   --mount=type=cache,target=/go/pkg/mod   --mount=type=bind,from=buildx-version,source=/buildx-version,target=/buildx-version <<EOT (set -e...):
0.068 + CGO_ENABLED=0 go build -mod vendor -trimpath -ldflags '-X github.com/docker/buildx/version.Version=df70f75 -X github.com/docker/buildx/version.Revision=df70f7519b6457f68692c0a14423d47667536db5 -X github.com/docker/buildx/version.Package=github.com/docker/buildx -s -w' -o /usr/bin/docker-buildx ./cmd/buildx
61.93 /usr/bin/docker-buildx: PE32+ executable for MS Windows 6.01 (console), ARM64, 6 sections
61.95 file /usr/bin/docker-buildx does not match expected target architecture arm64: PE32+ executable for MS Windows 6.01 (console), ARM64, 6 sections
------
Dockerfile:76
--------------------
  75 |     ARG GO_EXTRA_FLAGS
  76 | >>> RUN --mount=type=bind,target=. \
  77 | >>>   --mount=type=cache,target=/root/.cache \
  78 | >>>   --mount=type=cache,target=/go/pkg/mod \
  79 | >>>   --mount=type=bind,from=buildx-version,source=/buildx-version,target=/buildx-version <<EOT
  80 | >>>   set -e
  81 | >>>   xx-go --wrap
  82 | >>>   DESTDIR=/usr/bin VERSION=$(cat /buildx-version/version) REVISION=$(cat /buildx-version/revision) GO_EXTRA_LDFLAGS="-s -w" ./hack/build
  83 | >>>   file /usr/bin/docker-buildx
  84 | >>>   xx-verify --static /usr/bin/docker-buildx
  85 | >>> EOT
  86 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c   set -e\n  xx-go --wrap\n  DESTDIR=/usr/bin VERSION=$(cat /buildx-version/version) REVISION=$(cat /buildx-version/revision) GO_EXTRA_LDFLAGS=\"-s -w\" ./hack/build\n  file /usr/bin/docker-buildx\n  xx-verify --static /usr/bin/docker-buildx\n" did not complete successfully: exit code: 1
make: *** [Makefile:35: release] Error 1
Error: Process completed with exit code 2.

Yes this is similar to tonistiigi/xx#174 (comment) 😢

@crazy-max
Copy link
Member

@thaJeztah You can rebase

@crazy-max crazy-max mentioned this pull request Dec 10, 2024
Merged
@thaJeztah
Dockerfile: update to docker v27.4.0
c281e18 
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

Rebased; looks happy now 👍

@crazy-max crazy-max merged commit f9e2d07 into docker:master Dec 10, 2024
122 checks passed
@thaJeztah thaJeztah deleted the bump_engine_27.4 branch December 10, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazy-max crazy-max crazy-max approved these changes

Assignees

@thaJeztah thaJeztah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thaJeztah @crazy-max