[v0.19] bake: remove empty values set by --set #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/docker/buildx/actions/runs/12347799964/job/34460332018?pr=2861#step:6:183 Needs to pick the xx update edit: done in #2862, needs rebase |
These parser functions are called for `--set` to resolve entitlement paths that would be automatically added and will fail for empty value. The empty values would already be ignored but in v0.19 is done after merging the `--set` values and then calling parse again. Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
v0.19-set-empty-eof
branch
from
ccc391f to
9a9dd4e
Compare
crazy-max
approved these changes
Dec 16, 2024
Signed-off-by: CrazyMax <[email protected]>
|
@tonistiigi Pushed extra commit to test empty override |
crazy-max
reviewed
Dec 16, 2024
Comment on lines
+2032
to
+2047
| // https://github.com/docker/buildx/issues/2858 | ||
| func TestOverrideEmpty(t *testing.T) { | ||
| fp := File{ | ||
| Name: "docker-bake.hcl", | ||
| Data: []byte(` | ||
| target "app" { | ||
| output = ["./bin"] | ||
| } | ||
| `), | ||
| } | ||
|
|
||
| ctx := context.TODO() | ||
|
|
||
| _, _, err := ReadTargets(ctx, []File{fp}, []string{"app"}, []string{"app.output="}, nil, &EntitlementConf{}) | ||
| require.NoError(t, err) | ||
| } |
There was a problem hiding this comment.
Fyi @jsternberg, we should pick this in #2814
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regression from b2c0c26
fixes #2858 for v0.19
These parser functions are called for
--settoresolve entitlement paths that would be automatically added and will fail for empty value.
The empty values would already be ignored but in v0.19 is done after merging the
--setvalues and then calling parse again.