Skip sleep and warning of 'command_exists docker' when relevant flag is set #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is set Signed-off-by: Tasos Maschalidis <[email protected]>
Tashows
force-pushed
the
183-skip-docker-exists
branch
from
d465f3a to
a6f7db4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #183
- What I did
Added the ability to skip sleep related to
command_exists dockercheck.- How I did it
Added a relevant flag that skips block of code when it is present. Previous/Default functionality is not affected.
- How to verify it
Run
SKIP_DOCKER_EXISTS_WARN=true ./install.shvs./install.shto verify relevant warning and sleep time do not appear/occur.- Description for the changelog
Skip sleep and warning of 'command_exists docker' when
SKIP_DOCKER_EXISTS_WARNis set- A picture of a cute animal (not mandatory but encouraged)