Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update order of images in docker image tag command #21699

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nebojsatomic
Copy link

There was a mistake in the command for tagging an image that you have present in your list of images, order should be like this: docker image tag ALREADY_PRESENT_IMAGE IMAGE_THAT_YOU_WANT_TO_PUSH not the other way around

There was a mistake in the command for tagging an image that you have present in your list of images, order should be like this: 
'docker image tag ALREADY_PRESENT_IMAGE IMAGE_THAT_YOU_WANT_TO_PUSH'
not the other way around
@github-actions github-actions bot added the area/get-started Relates to get started and onboarding docs label Dec 29, 2024
Copy link

netlify bot commented Dec 29, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 6955bf7
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6771c1a001658c00084b8a73
😎 Deploy Preview https://deploy-preview-21699--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thaJeztah
Copy link
Member

Not sure if there's a direct mistake on the page though; the example looks to continue from the example shown a couple of lines above that shows that an image was built and tagged as my-username/my-image;

docker build -t my-username/my-image .

@nebojsatomic
Copy link
Author

nebojsatomic commented Dec 30, 2024

Not sure if there's a direct mistake on the page though; the example looks to continue from the example shown a couple of lines above that shows that an image was built and tagged as my-username/my-image;

docker build -t my-username/my-image .

Hm, yes,
but it is a bit confusing if you already have a built image with another name ( not my-username/my-image ) and you want to push my-username/my-image.
The text above docker image tag says "If you've already built an image" which could mean that you might not have to do the docker build -t, and you could have named your image previously web:latest for example.

Anyway, whatever you decide, is fine with me :)
@thaJeztah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/get-started Relates to get started and onboarding docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants