fix: clarified rprivate by adding spell out recursive private in volumes.md #21711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rashi Chaubal <[email protected]>
github-actions
bot
added
area/engine
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dvdksn
requested changes
Jan 6, 2025
| @@ -56,7 +56,7 @@ If your container generates non-persistent state data, consider using a | |||
| increase the container's performance by avoiding writing into the container's | |||
| writable layer. | |||
|
|
|||
| Volumes use `rprivate` bind propagation, and bind propagation isn't | |||
| Volumes use `rprivate (recursive private)` bind propagation, and bind propagation isn't | |||
There was a problem hiding this comment.
Two things:
- The term's clarification is now part of the
codeelement. I don't think it should be; it should just be plain text. - I think if we want to actually expand on this term here, we should add more detail. See this comment f.ex. What does [r] means in "[[r]shared|[r]slave|[r]private]" moby/moby#20502 (comment)
There was a problem hiding this comment.
@dvdksn For this PR can it be fixed for-
- The term's clarification should be plain text. ?
Please can you confirm?
There was a problem hiding this comment.
@dvdksn Changes made to PR.Can you please review
Signed-off-by: Rashi Chaubal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To avoid confusion of rprivate provided fix: clarified rprivate by adding spell out recursive private in volumes.md
Related issues or tickets
#21688
#21688
Reviews