Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support multiple drivers on single socket #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

support multiple drivers on single socket #68

wants to merge 1 commit into from

Conversation

mountkin
Copy link

@mountkin mountkin commented Jan 6, 2017 •
edited
Loading

Fixes #36

@wrouesnel
Copy link

So apparently I just wasted a few hours implementing this exactly idea again, in mostly the same way, in #70 :)

wrouesnel
wrouesnel reviewed Jan 13, 2017
View reviewed changes
sdk/handler.go
"net"
"net/http"
"os"
)

const activatePath = "/Plugin.Activate"

type muxInitilizaer func(*Handler)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo - should be muxInitializer.

wrouesnel
wrouesnel reviewed Jan 13, 2017
View reviewed changes
sdk/handler.go
"net"
"net/http"
"os"
)

const activatePath = "/Plugin.Activate"

type muxInitilizaer func(*Handler)

type activationResposne struct {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another typo - activationResponse

@wrouesnel wrouesnel mentioned this pull request Jan 13, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrouesnel wrouesnel wrouesnel left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mountkin @wrouesnel