Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fallback commit_date to author date and current date #477

Closed
wants to merge 2 commits into from
Closed

fix: fallback commit_date to author date and current date #477

wants to merge 2 commits into from

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Nov 19, 2024 •
edited
Loading

fix #476

@trim21 trim21 force-pushed the fix-commit-date branch 2 times, most recently from a8378b1 to e2f1776 Compare November 19, 2024 15:59
@crazy-max
Copy link
Member

Thanks didn't catch you already opened a PR 🚀

@crazy-max
Copy link
Member

Seems it always fail with the API: https://github.com/docker/metadata-action/actions/runs/11916882789/job/33210587618?pr=477#step:3:9

image

@trim21
get type hint
c8c17bf 
Signed-off-by: Trim21 <[email protected]>
@trim21 trim21 marked this pull request as ready for review November 19, 2024 16:26
@trim21
Copy link
Contributor Author

trim21 commented Nov 19, 2024

it should works.

@trim21
Copy link
Contributor Author

trim21 commented Nov 19, 2024 •
edited
Loading

toolkit.github.octokit.request should already have type hint but I didn't use expected request path so it become any in resposne.

therefore I didn't notice I'm not querying correct property 😅

@trim21 trim21 changed the title fix: fallback to author date and current date fix: fallback commit_date to author date and current date Nov 19, 2024
@crazy-max
Copy link
Member

Closing this one since #478 has been merged but thanks a bunch for taking a look at this!

@crazy-max crazy-max closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read properties of null (reading 'date')
2 participants
@trim21 @crazy-max