Skip to content

Commit

Permalink
Fix test failing on Windows
Browse files Browse the repository at this point in the history
Removed checking PHP_OS_FAMILY in favor of using is_link on
symlinked directory.
  • Loading branch information
srsbiz committed Dec 14, 2024
1 parent 1065fbe commit 1a7eb3e
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tests/Finder/RecursiveRegexFinderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,9 @@

use function count;
use function in_array;
use function is_link;
use function sort;

use const PHP_OS_FAMILY;

class RecursiveRegexFinderTest extends FinderTestCase
{
public function testBadFilenameCausesErrorWhenFindingMigrations(): void
Expand Down Expand Up @@ -43,11 +42,12 @@ public function testFindMigrationsReturnsTheExpectedFilesFromDirectory(): void
'TestMigrations\\DifferentNamingSchema',
];

if (PHP_OS_FAMILY !== 'Windows') {
// Some Windows installations may not support symlinks
if (is_link(__DIR__ . '/_files/_symlinked_files')) {
$tests[] = 'TestMigrations\\Version1SymlinkedFile';
}

self::assertCount(count($tests), $migrations); // Windows does not support symlinks
self::assertCount(count($tests), $migrations);
foreach ($tests as $fqcn) {
self::assertTrue(in_array($fqcn, $migrations, true));
}
Expand Down

0 comments on commit 1a7eb3e

Please sign in to comment.