Resolves #939 replaced single quotes with nowdoc

doctrine · Nov 29, 2024 · a8ef2a8 · a8ef2a8
1 parent 1065fbe
commit a8ef2a8
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 13 deletions.
diff --git a/src/Generator/SqlGenerator.php b/src/Generator/SqlGenerator.php
@@ -61,7 +61,10 @@ public function generate(
                 }
             }
 
-            $code[] = sprintf('$this->addSql(%s);', var_export($query, true));
+            $code[] = sprintf(
+                "\$this->addSql(<<<'SQL'\n%s\nSQL);",
+                preg_replace('/^/m', str_repeat(' ', 4), $query)
+            );
         }
 
         if (count($code) !== 0 && $checkDbPlatform && $this->configuration->isDatabasePlatformChecked()) {

diff --git a/tests/Generator/SqlGeneratorTest.php b/tests/Generator/SqlGeneratorTest.php
@@ -48,13 +48,19 @@ public function testGenerate(): void
                     "Migration can only be executed safely on '\\$expectedPlatform'."
                 );
                 
-                \$this->addSql('SELECT 1');
-                \$this->addSql('SELECT 2');
-                \$this->addSql('%s');
+                \$this->addSql(<<<'SQL'
+                    SELECT 1
+                SQL);
+                \$this->addSql(<<<'SQL'
+                    SELECT 2
+                SQL);
+                \$this->addSql(<<<'SQL'
+                    %s
+                SQL);
                 CODE,
         );
 
-        $code = $migrationSqlGenerator->generate($this->sql, true, 80);
+        $code = $migrationSqlGenerator->generate($this->sql, true, false,80);
 
         self::assertSame($expectedCode, $code);
     }
@@ -65,13 +71,19 @@ public function testGenerationWithoutCheckingDatabasePlatform(): void
 
         $expectedCode = $this->prepareGeneratedCode(
             <<<'CODE'
-                $this->addSql('SELECT 1');
-                $this->addSql('SELECT 2');
-                $this->addSql('%s');
+                \$this->addSql(<<<'SQL'
+                    SELECT 1
+                SQL);
+                \$this->addSql(<<<'SQL'
+                    SELECT 2
+                SQL);
+                \$this->addSql(<<<'SQL'
+                    %s
+                SQL);
                 CODE,
         );
 
-        $code = $this->migrationSqlGenerator->generate($this->sql, true, 80, false);
+        $code = $this->migrationSqlGenerator->generate($this->sql, true, false, 80, false);
 
         self::assertSame($expectedCode, $code);
     }
@@ -82,13 +94,19 @@ public function testGenerationWithoutCheckingDatabasePlatformWithConfiguration()
 
         $expectedCode = $this->prepareGeneratedCode(
             <<<'CODE'
-                $this->addSql('SELECT 1');
-                $this->addSql('SELECT 2');
-                $this->addSql('%s');
+                \$this->addSql(<<<'SQL'
+                    SELECT 1
+                SQL);
+                \$this->addSql(<<<'SQL'
+                    SELECT 2
+                SQL);
+                \$this->addSql(<<<'SQL'
+                    %s
+                SQL);
                 CODE,
         );
 
-        $code = $this->migrationSqlGenerator->generate($this->sql, true, 80);
+        $code = $this->migrationSqlGenerator->generate($this->sql, true, false,80);
 
         self::assertSame($expectedCode, $code);
     }