Add phpdoc for LogInterface::log() $message argument #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPStan complains that it is not specified. Looking at the method signature of Psr\Log\LoggerTrait, it appears that $level uses a phpdoc, and both $message and $context use native type declarations, so the corresponding phpdoc was removed in 3.0.1
|
Maybe the doc blocks shouldn't have been removed in the first place. 🤔 cc @lyrixx |
|
Maybe, but now that this ship has sailed, I wouldn't revert it I think. |
|
Shouldn't require 3.0.1 as minimum version fix the issue? |
|
I don't think it would, because the issue appears with 3.0.1 IMO |
SenseException
approved these changes
Aug 25, 2024
|
@SenseException since 3.0.1, there is nothing to inherit, the phpdoc was dropped in the PR I linked in my original message. |
derrabus
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPStan complains that it is not specified. Looking at the method signature of Psr\Log\LoggerTrait, it appears that $level uses a phpdoc, and both $message and $context use native type declarations, so the corresponding phpdoc was removed in 3.0.1