WIP Allow usage of Symfony EventDispatcher instead of Doctrine EventManager #2686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Symfony EventDispatcher is a very close to Doctrine EventManager in features (add/remove listener, and dispatch an event using a name and an event object).
Why not using sticking to PSR-14: Event Dispatcher?
The PSR EventDispatcher interface method
dispatch(object $event)
relies on the object class. But in Doctrine ODM, the same event classLifecycleEventArgs
is used for multiple events (postUpdate
,postRemove
,postUpdate
,prePersist
,preRemove
,preUpdate
).We can decide to create a distinct class for each event and use the PSR
EventDispatcherInterface
. With a map of class names to event names.The event names are very generic, it would be possible to prefix them with
doctrine.mongodb.
to prevent any conflict if the same event dispatcher is used for other events outside of Doctrine.Livecycle callbacks
The livecycle callbacks are not using the event manager, they are called independently in
LifecycleEventManager
.