Improve query and aggregator classes #2702
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To improve handling of query and aggregation classes, a new joint
IterableResult
interface is introduced. This method includes theexecute
,getIterator
, andgetSingleResult
methods that are common to both queries and aggregations. In addition, this allows us to keep the actual classes final, while allowing other platforms to mock what's returned from the builders for testing purposes.Note that while the return type of
getAggregation
andgetQuery
in the builders has widened, I've added an@return
statement to indicate that the methods themselves still return the same class instances that they returned previously. However, changing the return type is necessary to allow the mocking described above. So while this is technically a BC break, in practice it has no effect, especially as any class extending the builders would still be allowed to use the narrower return type.