Fix psalm errors: remove override of template type

See doctrine/collections#368 for the same issue in doctrine/collections which has been fixed there. The issue happens when using ->contains(). Running psalm emits > InvalidArgument - Argument 1 of Doctrine\ORM\PersistentCollection::contains > expects > TMaybeContained:fn-doctrine\common\collections\readablecollection::contains > as mixed, but … provided. We should either not define @template TMaybeContained or re-define the psalm docblock from ReadableCollection completely.
doctrine · Mar 20, 2024 · 0ff2a4f · 0ff2a4f
1 parent 55c4845
commit 0ff2a4f
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/src/LazyCriteriaCollection.php b/src/LazyCriteriaCollection.php
@@ -67,8 +67,6 @@ public function isEmpty(): bool
      * {@inheritDoc}
      *
      * Do an optimized search of an element
-     *
-     * @template TMaybeContained
      */
     public function contains(mixed $element): bool
     {

diff --git a/src/PersistentCollection.php b/src/PersistentCollection.php
@@ -352,8 +352,6 @@ public function containsKey(mixed $key): bool
 
     /**
      * {@inheritDoc}
-     *
-     * @template TMaybeContained
      */
     public function contains(mixed $element): bool
     {
-Original file line number
+Diff line change
@@ Expand Up / @@ -352,8 +352,6 @@ public function containsKey(mixed $key): bool @@
         /**
          * {@inheritDoc}
-         *
-         * @template TMaybeContained
          */
         public function contains(mixed $element): bool
         {
@@ Expand Down @@