something is odd with sqlite

doctrine · Nov 15, 2024 · 56ce570 · 56ce570
1 parent 75fa53c
commit 56ce570
Showing 1 changed file with 17 additions and 19 deletions.
diff --git a/src/UnitOfWork.php b/src/UnitOfWork.php
@@ -2390,29 +2390,27 @@ private function doDetach(
 
         $visited[$oid] = $entity; // mark visited
 
-        switch ($this->getEntityState($entity, self::STATE_DETACHED)) {
-            case self::STATE_MANAGED:
-                if ($this->isInIdentityMap($entity)) {
-                    $this->removeFromIdentityMap($entity);
-                }
+        $state = $this->getEntityState($entity, self::STATE_DETACHED);
+        if (! $noCascade && $state === self::STATE_MANAGED) {
+            $this->cascadeDetach($entity, $visited);
+        }
 
-                unset(
-                    $this->entityInsertions[$oid],
-                    $this->entityUpdates[$oid],
-                    $this->entityDeletions[$oid],
-                    $this->entityIdentifiers[$oid],
-                    $this->entityStates[$oid],
-                    $this->originalEntityData[$oid]
-                );
-                break;
-            case self::STATE_NEW:
-            case self::STATE_DETACHED:
-                return;
+        if ($state !== self::STATE_MANAGED) {
+            return;
         }
 
-        if (! $noCascade) {
-            $this->cascadeDetach($entity, $visited);
+        if ($this->isInIdentityMap($entity)) {
+            $this->removeFromIdentityMap($entity);
         }
+
+        unset(
+            $this->entityInsertions[$oid],
+            $this->entityUpdates[$oid],
+            $this->entityDeletions[$oid],
+            $this->entityIdentifiers[$oid],
+            $this->entityStates[$oid],
+            $this->originalEntityData[$oid]
+        );
     }
 
     /**