Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecate PARTIAL for array hydration. #11366

Merged

Conversation

beberlei
Copy link
Member

@beberlei beberlei marked this pull request as ready for review March 16, 2024 21:48
@beberlei beberlei requested review from greg0ire and derrabus March 16, 2024 21:48
@greg0ire
Copy link
Member

Please update UPGRADE.md as well 🙏

greg0ire
greg0ire previously approved these changes Mar 17, 2024
@beberlei beberlei added this to the 2.19.3 milestone Mar 19, 2024
stof
stof previously approved these changes Mar 20, 2024
@derrabus
Copy link
Member

Shouldn't we target 2.20 for this?

@derrabus derrabus changed the base branch from 2.19.x to 2.20.x March 20, 2024 14:46
@derrabus derrabus dismissed stale reviews from stof and greg0ire March 20, 2024 14:46

The base branch was changed.

@derrabus derrabus modified the milestones: 2.19.3, 2.20.0 Mar 20, 2024
@greg0ire
Copy link
Member

Shouldn't we target 2.20 for this?

@derrabus I don't think we should: #11365 will make this the deprecation wrong, which makes this PR a bugfix.

@derrabus
Copy link
Member

#11365 will make this the deprecation wrong, which makes this PR a bugfix.

#11365 isn't a bugfix either, which makes this change a forward compat improvement.

@beberlei
Copy link
Member Author

We made forward compatibility improvements in mini versions in DBAL, so I an with @greg0ire here that this can be in 2.19

@derrabus
Copy link
Member

But that's not what we agreed on in #11208.

@greg0ire
Copy link
Member

greg0ire commented Mar 21, 2024

@derrabus I think it would qualify as an improvement if there was something that should be deprecated but wasn't. Here, we are wrongly over-deprecating, causing extra work.

Just like static analysis tags can be imprecise and wrong and static analysis changes can go on patch or minor depending on whether they make things more accurate or more precise, this change is about making the deprecation more accurate. When #11365, the deprecation will become wrong, hence this is a bugfix, and complies with #11208 IMO, although I must admit it feels like an edge case/ gray area stuff, because it's correct today, and will suddenly become wrong tomorrow.

This relates to doctrine/doctrine-website#485

@beberlei
Copy link
Member Author

@derrabus @greg0ire if we put this in 2.20 you both ok with it?

@greg0ire
Copy link
Member

Yes

@derrabus derrabus merged commit 6874448 into doctrine:2.20.x Jun 18, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants