Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement compatibility with Persistence 4 #11533

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Implement compatibility with Persistence 4 #11533

merged 1 commit into from
Nov 4, 2024

Conversation

greg0ire
Copy link
Member

No description provided.

@greg0ire greg0ire force-pushed the persistence-4-compat branch 2 times, most recently from c2823b8 to 0dd9cda Compare June 27, 2024 22:01
@greg0ire greg0ire mentioned this pull request Jun 27, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

@github-actions github-actions bot added the Stale label Oct 15, 2024
@greg0ire
Copy link
Member Author

I promise I will resume work on this soon.

@github-actions github-actions bot removed the Stale label Oct 17, 2024
@greg0ire greg0ire changed the base branch from 3.3.x to 3.4.x October 27, 2024 11:48
@greg0ire greg0ire force-pushed the persistence-4-compat branch 4 times, most recently from 41bef65 to 20d3a45 Compare November 2, 2024 10:30
@greg0ire greg0ire marked this pull request as ready for review November 2, 2024 10:34
@greg0ire greg0ire mentioned this pull request Nov 2, 2024
Draft
@derrabus
Copy link
Member

derrabus commented Nov 3, 2024

Can we merge rebase the PR onto 2.21.x?

@greg0ire greg0ire force-pushed the persistence-4-compat branch from 20d3a45 to 4617e2e Compare November 3, 2024 19:12
@greg0ire
Copy link
Member Author

greg0ire commented Nov 3, 2024 •
edited
Loading

@derrabus 2.21.x requires doctrine/common, which is not compatible with persistence 4. Even if it were compatible, I don't see the benefit.

SenseException
SenseException previously approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those conditional traits are looking weird but I didn't find a solution how to solve this more elegantly. 😞

derrabus
derrabus reviewed Nov 3, 2024
View reviewed changes
phpstan.neon Outdated Show resolved Hide resolved
@greg0ire greg0ire force-pushed the persistence-4-compat branch from 4617e2e to c2563a2 Compare November 4, 2024 11:07
@greg0ire greg0ire force-pushed the persistence-4-compat branch from c2563a2 to 81c0d59 Compare November 4, 2024 11:15
@greg0ire greg0ire merged commit f41dc4a into doctrine:3.4.x Nov 4, 2024
86 checks passed
@greg0ire greg0ire added this to the 3.4.0 milestone Nov 4, 2024
@greg0ire greg0ire deleted the persistence-4-compat branch November 4, 2024 11:30
@greg0ire greg0ire mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@SenseException SenseException SenseException left review comments

@beberlei beberlei Awaiting requested review from beberlei

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@greg0ire @derrabus @SenseException