[GH-8471] Undeprecate PARTIAL for objects in DQL #11653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't it be "Revert deprecation of" or "Undeprecate" though? |
beberlei
changed the title
SenseException
requested changes
Oct 11, 2024
greg0ire
reviewed
Oct 12, 2024
| first access. This is possible in Java, for example, through | ||
| bytecode instrumentation. In PHP though this is not possible, so | ||
| there is no way to have "secure" partial objects in an ORM with | ||
| transparent persistence. |
There was a problem hiding this comment.
Is this sentence still true? Or should we say it's not implemented yet?
There was a problem hiding this comment.
Its still true until we get lazy objects.
beberlei
commented
Oct 12, 2024
Co-authored-by: Grégoire Paris <[email protected]>
SenseException
approved these changes
Oct 12, 2024
greg0ire
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR SELECT PARTIAL p.{} is allowed again with object hydration. It was already re-allowed for array-hydration a few commits before.
The reason we want to allow this again is that PHP 8.4 Lazy Proxies will allow us to implement partial objects as proxies that will trigger lazy initialization as soon as one of the "not loaded" partial properties is accessed.
Related: