Respect referencedColumnName defaults in custom naming strategies #11776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
previously approved these changes
Dec 22, 2024
tests/Tests/ORM/Mapping/NamingStrategy/CustomPascalNamingStrategy.php
Outdated
Show resolved
Hide resolved
|
Also, please squash your commits into one, since we're unlikely to revert one but not the other, and reuse the PR description as a commit message body, to make the git history as independent from external resources as possible. |
Previously, when using a custom naming strategy, explicitly declaring a JoinColumn required specifying the referencedColumnName always as it would default to id no matter the naming strategy. This PR changes it to be determines correctly. Ref doctrine#9558
greg0ire
approved these changes
Dec 23, 2024
SenseException
approved these changes
Dec 24, 2024
|
Thanks @curry684 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when using a custom naming strategy, explicitly declaring a
JoinColumnrequired specifying thereferencedColumnNamealways as it would default toidno matter the naming strategy. This PR fixes this omission.Refer to #9558 for full examples.