Add timestamps to package urls #263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now work around by by making our own tag. Pull request rails/rails#11707 will correct on next version of Rails
It doesn't appear to work with MiniTest
Jammit uses Rails tags_with_options for css tags, which no longer not includes the `type="text/css"` attribute
This way it matches Rails
Also convert a few instances of just assert foo==bar to use assert_equal so a better error message is generated
When Sass implemented source map support in version 3.4, the signature of Sass::SCSS::CssParser.new changed to require 3 arguments
Since Rails has not been "booted", it doesn't setup the "url_for" method which is called internally by the default url_options method. Over-ridding it with a blank definition allows the controller's methods to be tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.