Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install with pip from pypi #7

Open
NikolausDemmel opened this issue Jan 3, 2020 · 2 comments
Open

install with pip from pypi #7

NikolausDemmel opened this issue Jan 3, 2020 · 2 comments
Assignees
Labels
new feature Request new feature

Comments

@NikolausDemmel
Copy link

NikolausDemmel commented Jan 3, 2020

Thanks for publishing this library, it is very useful. Can it be added to pypi, to facilitate easy installation via pip install minisam? This also would allow easy install without sudo (pip install --user minisam).

You might then have to package sophus with it, since that is often not available as a system dependency, at least not on mac and ubuntu AFAIK.

For the record, I use the following steps to install minisam (just python package, and without sudo). Tested on macos and ubuntu 18.04.

# 1. install sophus

# a) check for registered setups of sophus; possibly remove old files
ls ~/.cmake/packages/Sophus/

# b) setup / register with cmake:
git clone https://github.com/strasdat/Sophus.git
cd Sophus
mkdir build && cd build
cmake ..
make -j8

# 2. install minisam (pip package)

git clone https://github.com/dongjing3309/minisam.git
cd minisam
mkdir build && cd build
cmake .. -DMINISAM_BUILD_PYTHON_PACKAGE=ON
# Note: using the following flags seems to make the solver hang in python:
# -DMINISAM_WITH_MULTI_THREADS=On -DMINISAM_WITH_MULTI_THREADS_NUM=8
make -j8
pip install --user .
@NikolausDemmel
Copy link
Author

Update: Looks like the solver hangs if I compile with threads and run it from python. I removed the cmake flags above.

@dongjing3309
Copy link
Owner

Will have a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request new feature
Projects
None yet
Development

No branches or pull requests

2 participants