Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More thorough support for retrieving OpenAPI routes in a case-sensitive manner #59568

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+122 −16
Open

More thorough support for retrieving OpenAPI routes in a case-sensitive manner #59568

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dbaf405
When retrieving optione, use the lowercase document name, too
sander1095 Dec 19, 2024
5ae64b6
Added tests for checking if options monitor uses case-insensitive doc…
sander1095 Dec 19, 2024
e39c52d
Add XML comments to prevent bugs in the future
sander1095 Dec 20, 2024
d28a74f
Improve comments on existing test
sander1095 Dec 20, 2024
e3aade7
Add new tests for DocumentProvider which should also work case-insens…
sander1095 Dec 20, 2024
e57774b
Fix build by adding necessary XML comment
sander1095 Dec 20, 2024
12633da
Fix build of tests
sander1095 Dec 20, 2024
b74bff1
Improve comments
sander1095 Dec 20, 2024
37d01d2
Fix incorrect tests
sander1095 Dec 20, 2024
3d318ca
Fix bugs around case-sensitive document names
sander1095 Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OpenApi/src/Extensions/OpenApiEndpointRouteBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public static IEndpointConventionBuilder MapOpenApi(this IEndpointRouteBuilder e
else
{
var document = await documentService.GetOpenApiDocumentAsync(context.RequestServices, context.RequestAborted);
var documentOptions = options.Get(documentName);
var documentOptions = options.Get(lowercasedDocumentName);
sander1095 marked this conversation as resolved.
Show resolved Hide resolved
using var output = MemoryBufferWriter.Get();
using var writer = Utf8BufferTextWriter.Get(output);
try
Expand Down
Loading