Treat stackalloc like array creation. #1237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gafter
added
the
meeting: discuss
Nigel-Ecma
requested changes
Dec 15, 2024
There was a problem hiding this comment.
Note: I have not reviewed the PR per se, just why it is failing grammar validation.
This PR will fail grammar validation as it changes a production that the validator itself alters to resolve MLR.
Before this PR can be committed a manual grammar validation will be required and the grammar validator updated (if the later is not done all future PRs will fail validation).
I’ll take responsibility for doing these, till then I'll block merging by checking “Request changes”.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1232