Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch markdownlint GH action to use super-linter #5809

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

MichaelSimons
Copy link
Member

@MichaelSimons MichaelSimons commented Aug 16, 2024

Related to #5316

Switched the MarkDown linter GH action to use the super-linter. This gives us the advantage of enabling other linters via a "flip of a switch". The configuration will be more standardized with the super-linter versus having separate GH actions/linters. The super-linter used the markdownlint tool we are already using so there should be no functional changes.

Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

1 similar comment
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@MichaelSimons MichaelSimons force-pushed the linter branch 5 times, most recently from 70833cd to 0f44a24 Compare August 16, 2024 20:54
@MichaelSimons MichaelSimons marked this pull request as ready for review August 16, 2024 20:59
@MichaelSimons MichaelSimons requested a review from a team as a code owner August 16, 2024 20:59
@MichaelSimons MichaelSimons enabled auto-merge (squash) August 16, 2024 21:27
name: Lint Code Base

on:
pull_request: null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to keep the path filter on this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept it off with the idea that we would enable other linters. Trying to manage the paths becomes unfeasible when you start doing this.

@MichaelSimons MichaelSimons requested a review from mthalman August 16, 2024 21:42
@MichaelSimons MichaelSimons merged commit d2cc556 into dotnet:main Aug 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants