[nightly] Fix markdown linting errors #5811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbussell
requested review from
joperezr,
a team and
jander-msft
as code owners
lbussell
changed the title
mthalman
approved these changes
Aug 19, 2024
| **The images from the dotnet/nightly repositories include last-known-good (LKG) builds for the next release of [.NET](https://github.com/dotnet/core).** | ||
|
|
||
| **See [dotnet](https://hub.docker.com/r/microsoft/dotnet-aspire-dashboard/) for images with official releases of [.NET](https://github.com/dotnet/core).** | ||
| > **Important**: The images from the dotnet/nightly repositories include last-known-good (LKG) builds for the next release of [.NET](https://github.com/dotnet/core). |
There was a problem hiding this comment.
I know this is unrelated to your changes but I'm surprised the linter is ok with having text before the top-level header has even been defined.
There was a problem hiding this comment.
That's because the . prefixed directories are not scanned. They break this rule which has a lot of value outside of this directory. I chose to leave them unscanned due to the overlap w/the GH readmes.
|
I apologize for enabling the lint GH action before ensuring nightly was all fixed up. That was an oversight on my part. |
lbussell
added a commit
to lbussell/dotnet-docker
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves markdown linting error:
README.md:3 MD036/no-emphasis-as-heading Emphasis used instead of a heading [Context: "IMPORTANT"]