Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tzdata-legacy package to Ubuntu Noble and Noble Chiseled extra images #6110

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

lbussell
Copy link
Contributor

Fixes #6078

@lbussell
Copy link
Contributor Author

lbussell commented Dec 11, 2024

The failing tests aren't right. They pass locally with freshly built images. The aspnet and runtime images got cached in this PR validation run. A no-cache build in nightly will fix this if we merge the PR.

This is kind of related: Image caching logic doesn't take into account dependencies from intermediate stages (#1455)

But the runtime-deps image isn't an intermediate stage in the runtime Dockerfile. It's the base.

Also I found this interesting from the build output:

Checking for cached image for 'src/runtime/8.0/noble-chiseled-extra/amd64/Dockerfile'

Sending HTTP request: https://mcr.microsoft.com/v2/dotnet/nightly/runtime-deps/manifests/8.0.11-noble-chiseled-extra-amd64
Image info's base image digest SHA: sha256:699a8cdfa13ca6c6bd9dafdb350abd706a9f98091cf082f432ba0432a592fec1
Latest base image digest SHA: sha256:699a8cdfa13ca6c6bd9dafdb350abd706a9f98091cf082f432ba0432a592fec1
Base image digests match: True
-- EXECUTING: git log -1 --format=format:%H src/runtime/8.0/noble-chiseled-extra/amd64/Dockerfile
e77a617a3321e8d3bcf577f4fc76470187bd4087
-- EXECUTION ELAPSED TIME: 00:00:00.0053220

Image info's Dockerfile commit: ***/blob/e77a617a3321e8d3bcf577f4fc76470187bd4087/src/runtime/8.0/noble-chiseled-extra/amd64/Dockerfile
Latest Dockerfile commit: ***/blob/e77a617a3321e8d3bcf577f4fc76470187bd4087/src/runtime/8.0/noble-chiseled-extra/amd64/Dockerfile
Dockerfile commits match: True

I didn't find sha256:699a8cdfa13ca6c6bd9dafdb350abd706a9f98091cf082f432ba0432a592fec1 in the response from the MCR API.

@lbussell
Copy link
Contributor Author

I have filed dotnet/docker-tools#1516 to track the caching issue here. Since we know the tests will work with a re-build, I'll merge this and start a no-cache build of all the Ubuntu Noble images.

@lbussell lbussell merged commit 43d5883 into dotnet:nightly Dec 11, 2024
91 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants