Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nullable annotations in update-dependencies project #6118

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

lbussell
Copy link
Contributor

@lbussell lbussell commented Dec 17, 2024

@richlander
Copy link
Member

This code is subject to out of bounds exception, yes?

string sha = content.Split(" ")[0];

@lbussell
Copy link
Contributor Author

lbussell commented Dec 17, 2024

This code is subject to out of bounds exception, yes?

string sha = content.Split(" ")[0];

How so?

If we get an unexpected result from the Chisel checksum file, that doesn't have a double-space " " in it, then string.Split will return an array of one string (the input string). Or am I looking at the wrong thing?

https://sharplab.io/#v2:EYLgtghglgdgNAFxAJwK7wCYgNQB8ACATAIwCwAUAG4TIAEAzrQLy0BErA3BdXfsQAyMW9AHQBlAA4AbKAgAUrWmwCUAbX4BdLuT4BOOX0HNhyjkA===

@richlander
Copy link
Member

Ah. I forgot/didn't realize that string.split worked that way. Makes sense.

@lbussell lbussell requested a review from mthalman December 17, 2024 19:51
@lbussell lbussell merged commit 5905bf6 into dotnet:nightly Dec 17, 2024
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants