[release/9.0-staging] Don't throw PendingModelChangesWarning when applying a specific migration #35353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35342
Port of #35343
Improvement of #35221
Description
In 9.0 we added a runtime warning that would throw by default when updating the database if there are any changes detected in the model that aren't reflected in the latest migration.
However, when applying a specific migration this warning is not relevant and could be confusing.
Customer impact
The workaround is to ignore the warning using options.
How found
Customer report on 9, part of a large stream of feedback around this warning.
Regression
Yes, from 8.
Testing
Test added
Risk
Low.