New Device: LED segment display 5641AS #2350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
area-device-bindings
|
@dotnet-policy-service agree |
jabberhams
commented
Aug 29, 2024
Ellerbach
reviewed
Aug 30, 2024
…s including removal of special overload for DP handling; added ReadMe for sample
Ellerbach
approved these changes
Oct 13, 2024
|
@Ellerbach there is a build failure in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New device
LedSegmentDisplay5641ASadded. The device has fewer display characteristics (no colon or degrees) and while other devices in the Display category were driven by backpacks over I2C, this code is full GPIO only. In addition to the device, a dedicated pin schemeLedSegmentDisplay5641ASPinSchemeis for mapping board pins to device pins, and a helper class translatesFonts to segment assignments. Readme also updated.My first contribution so looking for constructive feedback where necessary.
Microsoft Reviewers: Open in CodeFlow