Improve support for loading MSBuild in a non-default ALC. #11111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he MSBuild assemblies are loaded in.
If MSBuild is loaded in a collectible ALC, its plugin ALCs will be collectible as well.
|
Lucky PR number! 🍀 |
teo-tsirpanis
commented
Dec 8, 2024
There was a problem hiding this comment.
This class seems to be doing an AppDomain-specific thing, and all but one uses of it are guarded behind FEATURE_APPDOMAIN.
Does the class' functionality make sense for ALCs?
| { | ||
| return assembly; | ||
| return MSBuildLoadContext.ThisAssemblyLoadContext.LoadFromAssemblyName(assemblyName); |
There was a problem hiding this comment.
I think this achieves the same goal in a much more straightforward way. And since we load a specific name in a specific context we don't need to patch the version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6794.
AssemblyLoadContext.Defaultwe use the ALC that hosts MSBuild's own assemblies.MSBuildLoadContextis created as unloadable if the ALC that hosts MSBuild's own assemblies is unloadable.In most cases, including when running the MSBuild CLI, MSBuild is already loaded in the default ALC so this PR wouldn't change any behavior.