Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rafs: fix typo #1653

Merged
merged 1 commit into from
Dec 13, 2024
Merged

rafs: fix typo #1653

merged 1 commit into from
Dec 13, 2024

Conversation

liubogithub
Copy link
Collaborator

Fix an invalid info! usage.

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Fix an invalid info! usage.

Signed-off-by: Liu Bo <[email protected]>
@liubogithub liubogithub requested a review from a team as a code owner December 13, 2024 06:22
@liubogithub liubogithub requested review from bergwolf, changweige and adamqqqplay and removed request for a team December 13, 2024 06:22
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.01%. Comparing base (b175fc4) to head (61bf2f0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
rafs/src/fs.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1653      +/-   ##
==========================================
- Coverage   60.02%   60.01%   -0.01%     
==========================================
  Files         147      147              
  Lines       49583    49583              
  Branches    47037    47037              
==========================================
- Hits        29762    29759       -3     
- Misses      18040    18042       +2     
- Partials     1781     1782       +1     
Files with missing lines Coverage Δ
rafs/src/fs.rs 34.19% <0.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's fix the unrelated CI later.

@imeoer imeoer merged commit acdf021 into master Dec 13, 2024
42 of 46 checks passed
@liubogithub
Copy link
Collaborator Author

@imeoer just noticed one thing,
we should disallow devs push random branches to our repo, people should use their own repos instead to submit PRs.

@liubogithub liubogithub deleted the liubo/typo-1 branch December 13, 2024 06:54
@imeoer
Copy link
Collaborator

imeoer commented Dec 16, 2024

@liubogithub Probably because you have admin privilege. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants