fix: dragonflyoss#1644 and #1651 resolve Algorithm to_string and FromStr inconsistency #1656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
Fixes: #1644
Fixes: #1651
Details
This Pull Request addresses the inconsistency between the
to_string
andFromStr
implementations for theAlgorithm
enum.Previously:
to_string
method generated PascalCase outputs (e.g.,Zstd
).FromStr
implementation expected lowercase strings (e.g.,zstd
).This caused parsing issues where the output of
to_string
could not be used as input forFromStr
.Changes:
Display
trait for theAlgorithm
enum to ensureto_string
produces lowercase strings matchingFromStr
.Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.