Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new config option rails_webpacker_use_webpacker4 #82

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

zealot128
Copy link
Contributor

Webpacker 4 changed default config files babelrc and postcssrc:
rails/webpacker@8d496a0

Thus, the default export is different in this case....

not totally fan of the conditional :/

/cc @hendrixfan

@arBmind
Copy link
Member

arBmind commented Apr 26, 2019

The reasoning seems legit.

I'm also not a fan of multiple bool variables. I suggest to simply use rails_webpacker: 4
The conditional might be enhanced later, but the variables are hard to change once established.

@zealot128 zealot128 force-pushed the webpacker4 branch 2 times, most recently from 7e130f4 to b18fd0e Compare April 27, 2019 21:42
@zealot128
Copy link
Contributor Author

Great suggestion, fixed it!

Copy link
Member

@arBmind arBmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Seems legit.
Once TravisCI works again, this should be merged.

@zealot128
Copy link
Contributor Author

Yeah... that rvm public key has changed ....

Had this problem also for newer Ruby versions.

Something like this fixed it for a new system:

rvm_gpg_keys: '7D2BAF1CF37B13E2069D6956105BD0E739499BDB 409B6B1796C275462A1703113804BB82D39DC0E3'
rvm_gpg_key_server: 'hkp://keys.gnupg.net'

Unfortunately, if the script already imported the old pubkey, than gpg --list-keys returns 0 = success, even when called with two keys.

Do you or any other people working on fixing CI?
Otherwise.. I might look into it, maybe add one of our own OS apps as a second test case with sidekiq and stuff (HRfilter).

Webpacker 4 changed default config files babelrc and postcssrc:
rails/webpacker@8d496a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants