-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: optional where clause in relations #1451
Open
Angelelz
wants to merge
11
commits into
drizzle-team:beta
Choose a base branch
from
Angelelz:feat-optional-where-in-relations
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat: optional where clause in relations #1451
Angelelz
wants to merge
11
commits into
drizzle-team:beta
from
Angelelz:feat-optional-where-in-relations
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angelelz
force-pushed
the
feat-optional-where-in-relations
branch
2 times, most recently
from
November 10, 2023 02:25
d9fc213
to
cd3f210
Compare
Any update on this? |
Hey just saw this, it would be really nice to have this merged |
- [All] Added new types to allow a one field to be null if it has a where - [MySql] Added type tests - [MySql] Fixed integration tests
Angelelz
force-pushed
the
feat-optional-where-in-relations
branch
from
December 27, 2023 02:26
746acd8
to
cfa1c1d
Compare
Hi, this looks amazing. Would love to have this merged in. |
Is there any update on this? Would love to have this in the next release! |
+1 Yes please! |
Folks, relational API v2 is discussed at #2316 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #1437, and will close #1051, will address part of #674 and part of #821.
Upon successful merging of this PR, a new
where
option will be added to the relation configuration. The most obvious use case is to better support for polymorphic associations when you'll like to associate a table with another one, only when a condition is met:The new
where
configuration option is also available in theone
relation.Please note that adding a where condition in the
one
relation will mark that field as nullable even if the column is not nullable, as we don't have a way of knowing at compile time if any row will be returned from the DB.