Improve with clause
#1578
Merged
Improve with clause
#1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add update, insert and delete methods to with clause for MySQL and SQLite
Add tests for `db.with().insert()`, `db.with().delete()` and `db.with().update()` for all dialects
|
great job, when we can expect this to be released? |
AndriiSherman
requested review from
AndriiSherman
and removed request for
dankochetov
|
@L-Mario564 this PR looks good. Could you please resolve all the conflicts so I can merge it to beta? |
|
@AndriiSherman Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #344 and #1541.
This PR makes it so you can use a
withclause alongsideinsert,updateanddelete.Things worth mentioning:
with ... insert.selectDistinctandselectDistinctOnwere added as well for the PG dialect.