Feat: allow empty arrays to passed to inArray and notInArray

drizzle-orm/src/sql/expressions/conditions.ts

@@ -289,7 +289,7 @@ export function inArray(
 ): SQL {
 	if (Array.isArray(values)) {
 		if (values.length === 0) {
-			throw new Error('inArray requires at least one value');
+			return sql`false`;
 		}
 		return sql`${column} in ${values.map((v) => bindIfParam(v, column))}`;
 	}
@@ -335,7 +335,7 @@ export function notInArray(
 ): SQL {
 	if (Array.isArray(values)) {
 		if (values.length === 0) {
-			throw new Error('notInArray requires at least one value');
+			return sql`true`;
 		}
 		return sql`${column} not in ${values.map((v) => bindIfParam(v, column))}`;
 	}

integration-tests/tests/libsql.test.ts

@@ -20,6 +20,7 @@ import {
 	min,
 	Name,
 	name,
+	notInArray,
 	placeholder,
 	sql,
 	sum,
@@ -956,6 +957,28 @@ test.serial('select with group by complex query', async (t) => {
 	t.deepEqual(result, [{ name: 'Jane' }]);
 });
 
+test.serial('select with empty array in inArray', async (t) => {
+	const { db } = t.context;
+
+	await db.insert(usersTable).values([{ name: 'John' }, { name: 'Jane' }, { name: 'Jane' }]);
+
+	const result = await db.select({ name: usersTable.name }).from(usersTable)
+		.where(inArray(usersTable.id, []));
+
+	t.deepEqual(result, []);
+});
+
+test.serial('select with empty array in notInArray', async (t) => {
+	const { db } = t.context;
+
+	await db.insert(usersTable).values([{ name: 'John' }, { name: 'Jane' }, { name: 'Jane' }]);
+
+	const result = await db.select({ name: usersTable.name }).from(usersTable)
+		.where(notInArray(usersTable.id, []));
+
+	t.deepEqual(result, [{ name: 'John' }, { name: 'Jane' }, { name: 'Jane' }]);
+});
+
 test.serial('build query', async (t) => {
 	const { db } = t.context;
 

integration-tests/tests/mysql.test.ts

@@ -20,6 +20,7 @@ import {
 	max,
 	min,
 	Name,
+	notInArray,
 	placeholder,
 	sql,
 	sum,
@@ -760,6 +761,28 @@ test.serial('select with group by as column + sql', async (t) => {
 	t.deepEqual(result, [{ name: 'John' }, { name: 'Jane' }, { name: 'Jane' }]);
 });
 
+test.serial('select with empty array in inArray', async (t) => {
+	const { db } = t.context;
+
+	await db.insert(usersTable).values([{ name: 'John' }, { name: 'Jane' }, { name: 'Jane' }]);
+
+	const result = await db.select({ name: usersTable.name }).from(usersTable)
+		.where(inArray(usersTable.id, []));
+
+	t.deepEqual(result, []);
+});
+
+test.serial('select with empty array in notInArray', async (t) => {
+	const { db } = t.context;
+
+	await db.insert(usersTable).values([{ name: 'John' }, { name: 'Jane' }, { name: 'Jane' }]);
+
+	const result = await db.select({ name: usersTable.name }).from(usersTable)
+		.where(notInArray(usersTable.id, []));
+
+	t.deepEqual(result, [{ name: 'John' }, { name: 'Jane' }, { name: 'Jane' }]);
+});
+
 test.serial('select with group by complex query', async (t) => {
 	const { db } = t.context;
 

integration-tests/tests/pg.test.ts

@@ -22,6 +22,7 @@ import {
 	max,
 	min,
 	name,
+	notInArray,
 	placeholder,
 	type SQL,
 	sql,
@@ -1728,6 +1729,28 @@ test.serial('array types', async (t) => {
 	t.deepEqual(res, values);
 });
 
+test.serial('select with empty array in inArray', async (t) => {
+	const { db } = t.context;
+
+	await db.insert(usersTable).values([{ name: 'John' }, { name: 'Jane' }, { name: 'Jane' }]);
+
+	const result = await db.select({ name: usersTable.name }).from(usersTable)
+		.where(inArray(usersTable.id, []));
+
+	t.deepEqual(result, []);
+});
+
+test.serial('select with empty array in notInArray', async (t) => {
+	const { db } = t.context;
+
+	await db.insert(usersTable).values([{ name: 'John' }, { name: 'Jane' }, { name: 'Jane' }]);
+
+	const result = await db.select({ name: usersTable.name }).from(usersTable)
+		.where(notInArray(usersTable.id, []));
+
+	t.deepEqual(result, [{ name: 'John' }, { name: 'Jane' }, { name: 'Jane' }]);
+});
+
 test.serial('select for ...', (t) => {
 	const { db } = t.context;
 

integration-tests/tests/postgres.js.test.ts

@@ -17,6 +17,7 @@ import {
 	lt,
 	Name,
 	name,
+	notInArray,
 	placeholder,
 	type SQL,
 	sql,
@@ -1318,6 +1319,28 @@ test.serial('select count w/ custom mapper', async (t) => {
 	t.deepEqual(res, [{ count: 2 }]);
 });
 
+test.serial('select with empty array in inArray', async (t) => {
+	const { db } = t.context;
+
+	await db.insert(usersTable).values([{ name: 'John' }, { name: 'Jane' }, { name: 'Jane' }]);
+
+	const result = await db.select({ name: usersTable.name }).from(usersTable)
+		.where(inArray(usersTable.id, []));
+
+	t.deepEqual(result, []);
+});
+
+test.serial('select with empty array in notInArray', async (t) => {
+	const { db } = t.context;
+
+	await db.insert(usersTable).values([{ name: 'John' }, { name: 'Jane' }, { name: 'Jane' }]);
+
+	const result = await db.select({ name: usersTable.name }).from(usersTable)
+		.where(notInArray(usersTable.id, []));
+
+	t.deepEqual(result, [{ name: 'John' }, { name: 'Jane' }, { name: 'Jane' }]);
+});
+
 test.serial('select for ...', (t) => {
 	const { db } = t.context;