Fix: select from subquery not qualifying field #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low qualifying aliased fields properly
…tion on each dialect
|
Is there a plan to ship this soon? Would solve many problems for us and make user code much cleaner. |
|
Any updates on this? @Angelelz |
|
We might actually get GTA 6 before this PR gets merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1242
Currently
SQL.Aliasedfields in subqueries and CTEs are not being qualified to the subquery/CTE alias.qualifierproperty to the SQL.Aliased class to allow qualifying aliased fields properly