Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSS C-API 0.14 and updated tests #97

Merged
merged 5 commits into from
Feb 18, 2024
Merged

DSS C-API 0.14 and updated tests #97

merged 5 commits into from
Feb 18, 2024

Conversation

PMeira
Copy link
Member

@PMeira PMeira commented Dec 13, 2023

Although there are a lot of changes in DSS C-API, not many changes on the Julia side, including the tests.

Of special note, to avoid changing the tests that compare property names just yet, the new Settings_SetPropertyNameStyle is used to toggle the legacy capitalization for the property names.

  • Use the final v0.14.1 release
  • Include/expose some new functions and enumerations
  • Add release notes
  • Update any docs if required
  • Add a few simple tests to ensure basic Circuit.Save, Circuit.ToJSON, and Circuit.FromJSON work.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (34e3db2) 59.50% compared to head (3bea0cf) 59.58%.

Files Patch % Lines
src/extensions.jl 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   59.50%   59.58%   +0.08%     
==========================================
  Files          55       55              
  Lines        8591     8609      +18     
==========================================
+ Hits         5112     5130      +18     
  Misses       3479     3479              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PMeira PMeira force-pushed the dss_capi-0.14.0 branch 3 times, most recently from 5d1e554 to 64c4da3 Compare February 9, 2024 14:54
@PMeira PMeira marked this pull request as ready for review February 18, 2024 16:45
@PMeira PMeira merged commit fc8918d into master Feb 18, 2024
22 checks passed
@PMeira PMeira deleted the dss_capi-0.14.0 branch February 18, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants