Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Background image gets cropped when Opening the Help Center in Mo… #1533

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Anonymous096
Copy link

@Anonymous096 Anonymous096 commented Oct 16, 2024

What does this PR do?

Fixed the UI Background image gets cropped when Opening the Help Center in Mobile Responsive on /onboarding/welcome

Fixes #1428

How should this be tested?

  • Login to the app.dub.co
  • After you logged in you will be redirected to app.dub.co/onboarding/wecome page change it to responsive mode if on desktop

Copy link

vercel bot commented Oct 16, 2024

Someone is attempting to deploy a commit to the Dub Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ steven-tey
❌ Saksham Sharma


Saksham Sharma seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

socket-security bot commented Oct 16, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

@steven-tey
Copy link
Collaborator

steven-tey commented Oct 18, 2024

@Anonymous096 thanks for the PR! can you sign the CLA please?

@steven-tey
Copy link
Collaborator

it's still broken btw:

CleanShot 2024-10-18 at 15 35 31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🕹️] Background image gets cropped when Opening the Help Center in Mobile Responsive
3 participants