Test Iterable Data #128
Open
Test Iterable Data #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a test class, Vector, implementing \Iterator and a corresponding test case in the SerializerTest that demonstrates iterable data doesn't play nice with the serializer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't meant to be merged, it's just a test case illustrating that the serializer doesn't play nice with classes implementing \Iterator as pointed out in #127
If you clone this branch, run the tests, and put a breakpoint before the assert in
testIterable, you'll see the serialized output of the Vector class in$datais:{"#type":"Dunglas\\DoctrineJsonOdm\\Tests\\Fixtures\\TestBundle\\Document\\Vector","0":1,"1":2,"2":3,"3":4,"4":5}Which cannot be deserialized and the test fails
If you remove the \Iterator interface from the Vector class and re-run the tests, this is the serialized output in
$data:{"#type":"Dunglas\\DoctrineJsonOdm\\Tests\\Fixtures\\TestBundle\\Document\\Vector","array":[1,2,3,4,5]}Which can be deserialized and the test passes