Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum deps compatibility #133

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Bump minimum deps compatibility #133

merged 4 commits into from
Jan 16, 2024

Conversation

amenophis
Copy link
Contributor

This PR remove compatibility with php < 8.1 and symfony < 5.4.
It also add compatibility with symfony 7.0

@amenophis amenophis force-pushed the symfony7 branch 2 times, most recently from 122bc9f to 70ed045 Compare December 5, 2023 12:39
@amenophis
Copy link
Contributor Author

amenophis commented Dec 5, 2023

@dunglas Don't know why i have to add the dependency on symfony/validator, any idea ?

The error was:
PHP Fatal error: During class fetch: Uncaught ReflectionException: Class "Symfony\Component\Validator\Mapping\Loader\AutoMappingTrait" not found while loading "Symfony\Bridge\Doctrine\Validator\DoctrineLoader". in /home/jeremy/dev/github.com/amenophis/dunglas-doctrine-json-odm/vendor/symfony/error-handler/DebugClassLoader.php:337

@amenophis amenophis mentioned this pull request Dec 5, 2023
@dunglas
Copy link
Owner

dunglas commented Dec 5, 2023

That's likely a bug (a missing class_exists() in Symfony).

@amenophis
Copy link
Contributor Author

ok, @dunglas do you think it can be merged in state (and released), or should we fix the symfony bug before ?

@back-2-95
Copy link
Contributor

Is there some Symfony issue which this is waiting?

@dunglas dunglas merged commit 2c0be0e into dunglas:main Jan 16, 2024
5 checks passed
@dunglas
Copy link
Owner

dunglas commented Jan 16, 2024

Thank you @amenophis!!

@amenophis amenophis deleted the symfony7 branch January 16, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants